[tbb-bugs] #22002 [Applications/Tor Browser]: Backport Mozilla's SVG-disabling patch

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Apr 20 07:44:48 UTC 2017


#22002: Backport Mozilla's SVG-disabling patch
--------------------------------------+--------------------------
 Reporter:  arthuredelstein           |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  ff52-esr                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:4 arthuredelstein]:
 > Replying to [comment:2 gk]:
 > > Why do we want to backport that patch if things are missing and we
 have a working patch in our tree?
 >
 > We don't have to necessarily. Because the backport seemed to fix the
 crash, I was attempting to work with it, but found several missing edges
 cases. That's why I suggested in #21962 that we stick with the working
 patch, with Mark and Kathy's fixup.
 >
 > In the long run, given that we hope to reduce our maintenance by
 uplifting our SVG-disabling code, it seems to make sense that we would
 backport the Mozilla patch and add back the missing parts. Or we could ask
 Mozilla to work on that.

 Asking Mozilla to add the missing pieces seems like a good idea to me as I
 guess they are more familiar with the way the patch on m-c is written.
 Adding the remaining things should be faster that way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22002#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list