[tbb-bugs] #22002 [Applications/Tor Browser]: Backport Mozilla's SVG-disabling patch
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Apr 19 19:43:34 UTC 2017
#22002: Backport Mozilla's SVG-disabling patch
--------------------------------------+--------------------------
Reporter: arthuredelstein | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-security | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------
Comment (by arthuredelstein):
Replying to [comment:2 gk]:
> Why do we want to backport that patch if things are missing and we have
a working patch in our tree?
We don't have to necessarily. Because the backport seemed to fix the
crash, I was attempting to work with it, but found several missing edges
cases. That's why I suggested in #21962 that we stick with the working
patch, with Mark and Kathy's fixup.
In the long run, given that we hope to reduce our maintenance by uplifting
our SVG-disabling code, it seems to make sense that we would backport the
Mozilla patch and add back the missing parts. Or we could ask Mozilla to
work on that.
FWIW, here is my WIP branch. I'm going to leave it at this stage until we
decide on what to do.
https://github.com/arthuredelstein/tor-browser/commits/22002_wip
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22002#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list