[tbb-bugs] #19316 [Applications/Tor Browser]: Make sure our updates are dealing with SSE requirement properly

[Tor Bug Tracker & Wiki]

#19316: Make sure our updates are dealing with SSE requirement properly
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201704,      |  Actual Points:
  tbb-7.0-must-alpha                             |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:12 boklm]:
 > I made a build with version 2 of the patch:
 > https://people.torproject.org/~boklm/builds/bug19316/
 >
 > I did not yet find a computer without SSE3 (or how to emulate one) to
 test it.

 I have no computer without SSE2 support (and could not find how to emulate
 one), so I tested with SSE4A (which is not supported on my computer since
 it seems to be AMD only).

 If I set this url as `app.update.url.override`:
 https://people.torproject.org/~boklm/bug19316/SSE4A.xml
 Then the update is not started, with a message saying "You Tor Browser is
 out of date, but the latest version is not supported on your system".

 If I set this url as `app.update.url.override`:
 https://people.torproject.org/~boklm/bug19316/SSE2.xml
 Then the updating process is starting.

 So the patch seems to be working as expected.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19316#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online