[tbb-bugs] #12426 [Applications/Tor Browser]: Make use of HeapEnableTerminationOnCorruption in Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#12426: Make use of HeapEnableTerminationOnCorruption in Tor Browser on Windows
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:  fixed
 Keywords:  tbb-security, tbb-firefox-patch,     |  Actual Points:
  tbb-hardened, tbb-easy, TorBrowserTeam201704R  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Replying to [comment:7 gk]:
 > FWIW: We want to test it an alpha but think harder if we should pick
 that one for the 7.0 stable in case we don't get the sandbox compiled
 properly in time.
 ???
 It has been tested in stable since 2012 when Win 8 was released which
 terminated all processes on heap corruption by default without any need
 for asking it through HeapSetInformation() calls. It is needed only for
 Win 7 or earlier. Would be nice to see it in 6.5 (in tor.exe near
 SetProcessDEPPolicy() too).
 FWIW: we should also add EnableLowFragmentationHeap() modified from
 https://dxr.mozilla.org/mozilla-
 esr24/source/ipc/chromium/src/base/process_util_win.cc#867, but it's not
 so easy.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12426#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online