[tbb-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

[Tor Bug Tracker & Wiki]

#20680: Rebase Tor Browser patches to 52 ESR
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,              |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:48 arthuredelstein]:
 > Replying to [comment:47 gk]:
 > > Arthur, one thing I forgot: what happend to our DNS leak prevention
 patch? It seems it did not get rebased? Looking above you seem to imply it
 got upstreamed. I found you pointing to bug 751465 but what is the other
 commit you had in mind.
 >
 > Turns out I inadvertently deleted the first digit in the hash (I edited
 the comment above to fix this). I intended to point to the test for 751465
 you provided at `ef52c3bbf96f317d461ad652970f817e78923531`. Do these two
 patches cover the problem reported in #5741, or do we need the Tor Browser
 patch as well?

 That specific problem should be fixed by that, yes. However, the patch we
 had so far is more general than that as it prevents any DNS leaks not only
 the WebSocket related one.

 >
 > > I think I am inclined to take that patch again until we can be sure
 Mozilla is taking our proxy bypass safety requirements pretty seriously.
 >
 > Here's a rebased version, in case we still need it:
 > https://github.com/arthuredelstein/tor-browser/commit/20680+10_5741

 Thanks, I picked that one and applied it on `tor-browser-52.0.2esr-7.0-2`
 (e81b5bba67dd3c08f76b4d8e76d04743db202011).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20680#comment:50>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online