[tbb-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

[Tor Bug Tracker & Wiki]

#20680: Rebase Tor Browser patches to 52 ESR
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,              |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:47 gk]:
 > Arthur, one thing I forgot: what happend to our DNS leak prevention
 patch? It seems it did not get rebased? Looking above you seem to imply it
 got upstreamed. I found you pointing to bug 751465 but what is the other
 commit you had in mind.

 That is strange, because I can't find that hash either now. I think I
 intended to point to the test for 751465 you provided at
 `ef52c3bbf96f317d461ad652970f817e78923531`. Do these two patches cover the
 problem reported in #5741 or do we need the Tor Browser patch as well?

 > I think I am inclined to take that patch again until we can be sure
 Mozilla is taking our proxy bypass safety requirements pretty seriously.

 Here's a rebased version, in case we still need it:
 https://github.com/arthuredelstein/tor-browser/commit/20680+10_5741

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20680#comment:48>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online