[tbb-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Apr 4 16:28:58 UTC 2017


#20680: Rebase Tor Browser patches to 52 ESR
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,              |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:41 mcs]:
 Sorry, I missed this part:

 > Here are the additional things that we noticed:
 > * The second call to `CanvasPermissionPromptHelper.init();` should be
 `.uninit();`

 Fixed.

 > * In `browser/base/content/browser.xul`, the class `canvas-icon` was
 added but Kathy and I do not see why it is needed.

 Removed.

 > * In `dom/canvas/OffscreenCanvas.cpp`, maybe add a reference to #18599
 and also mention that for now placeholder image data is always returned to
 users of OffscreenCanvas.

 Added.

 These are a fixup patch appended to
 ‚Äčhttps://github.com/arthuredelstein/tor-browser/commits/20680+10

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20680#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list