[tbb-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

[Tor Bug Tracker & Wiki]

#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-------------------------------------------------+-------------------------
 Reporter:  yawning                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very Low                             |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,          |  Actual Points:
  TorBrowserTeam201609R                          |
Parent ID:  #14270                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:9 arthuredelstein]:
 > Replying to [comment:7 mcs]:
 > > Here is a new patch:
 > >
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-02&id=f1932e73ee5199969f49ce595fb30ec14e76cb52
 > Minor things:
 > {{{
 > + if (socksAddr && (socksAddr.substr(0, 5) == "file:")) {
 > }}}
 > Can this be `sockAddr.startsWith("file:")`?

 Done.

 > {{{
 > + foundSocksListener = (socketPath == path);
 > }}}
 > {{{
 > +          foundSocksListener = ((socksAddr == torSocksAddr) &&
 > +                                (socksPort == torSocksPort));
 > }}}
 > I would suggest using `===` (triple equals) for safety.

 OK. We fixed another place too where == was used instead of ===. While
 testing, we discovered that file: URLs that begin with file:/// were not
 handled correctly (and they should begin that way). So we rewrote the code
 that converts the network.proxy.socks value to a file path. Please review:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-03&id=a07ceb4e7974a1369a1d6484cbfce0a7ec9e503f

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19733#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online