[tbb-bugs] #20185 [Applications/Tor Browser]: Tor Browser alpha is broken on Linux (and probably OS X) if directory is nested too deep

[Tor Bug Tracker & Wiki]

#20185: Tor Browser alpha is broken on Linux (and probably OS X) if directory is
nested too deep
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Major                     |     Resolution:
 Keywords:  TorBrowserTeam201610      |  Actual Points:
Parent ID:  #14270                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201610R => TorBrowserTeam201610
 * status:  needs_review => needs_revision


Comment:

 The code breaks for me in `_createUniqueIPCDir()` adding some logging
 gives me:
 {{{
 TorLauncher NOTE: Failed to create unique dir: [Exception... "Component
 returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)
 [nsIFile.createUnique]"  nsresult: "0x80520015
 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame ::
 resource://torlauncher/modules/tl-util.jsm ::
 TLUtilInternal._createUniqueIPCDir :: line 823"  data: no] with aBasePath
 /run/user/1000
 }}}

 + there are again some places where you mix blocks with and without braces
 in if-else statements.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20185#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online