[tbb-bugs] #20184 [Applications/Tor Browser]: OS X builds are still not reproducible on some machines

[Tor Bug Tracker & Wiki]

#20184: OS X builds are still not reproducible on some machines
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-gitian, GeorgKoppen201610,       |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:7 gk]:
 > bug_20184_v2 (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_20184_v2&id=8cb911a5516dd89e99a429d2c2f5912e3a6a326c)
 in my public tor-browser-bundle has a patch up for review. I tested it on
 different machines with several builds and I got always the same .zip
 file. Looking at the artifacts the differences mentioned in comment:1 2)
 are gone. However, we got a new one only in `libcurve25519_donna.a` which
 is probably a bug in the `ar` tool used. There are always two bytes
 different, e.g.:
 > {{{
 > @@ -5,7 +5,7 @@
 >  00000040: 2020 600a 5f5f 2e53 594d 4445 4620 534f    `.__.SYMDEF SO
 >  00000050: 5254 4544 0000 0000 0800 0000 0000 0000  RTED............
 >  00000060: 8000 0000 1800 0000 5f63 7572 7665 3235  ........_curve25
 > -00000070: 3531 395f 646f 6e6e 6100 d900 0000 0000  519_donna.......
 > +00000070: 3531 395f 646f 6e6e 6100 6c01 0000 0000  519_donna.l.....
 >  00000080: 2331 2f36 3020 2020 2020 2020 2020 2020  #1/60
 >  00000090: 3934 3636 3834 3830 3020 2020 3130 3030  946684800   1000
 >  000000a0: 2020 3130 3030 2020 3130 3036 3434 2020    1000  100644
 > }}}
 > It does not affect us at the moment, though.
 >
 > For some reason `libfaketime` is needed again which is a bit surprising
 and might merit further investigation as we don't seem to need it in the
 gitian-firefox.yml descriptor.
 >
 > I've uploaded a test bundle as I only have an old OSX 10.6 machine
 available (where it worked):
 >
 > https://people.torproject.org/~gk/testbuilds/TorBrowser-6.5a3
 -osx64_20184_en-US.dmg
 > https://people.torproject.org/~gk/testbuilds/TorBrowser-6.5a3
 -osx64_20184_en-US.dmg.asc

 I ran this on a 10.11.5 OS X machine and it everything seems to be working
 as expected.

 I happened to notice in the patch the following change:
 {{{
 -  i686-apple-darwin11-install_name_tool -change
 $INSTDIR/libevent/lib/$LIBEVENT_FILE @executable_path/$LIBEVENT_FILE tor
 +  x86_64-apple-darwin10-install_name_tool -change
 $INSTDIR/libevent/lib/$LIBEVENT_FILE @executable_path/$LIBEVENT_FILE tor
 }}}
 Is there a reason this is changing from "darwin11" to "darwin10"? I'm not
 familiar with this tool, so sorry if this is a naive question.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20184#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online