[tbb-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Nov 22 17:59:39 UTC 2016

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-usability,                       |  Actual Points:
  TorBrowserTeam201611R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:

Comment (by arthuredelstein):

 Replying to [comment:5 mcs]:
 > Replying to [comment:2 arthuredelstein]:
 > > ... Therefore I'm proposing this separate follow-up patch that removes
 the references for Tor Browser only.
 > >
 > > https://github.com/arthuredelstein/tor-browser/commit/20707
 > r=mcs
 > I think this is an okay solution, although it looks strange to use hard-
 coded strings.
 > Maybe the commit message state that this is a fixup for 20244 instead of
 using this new ticket number?

 The reason I did it this way is that I wanted to keep the original patch
 separate for possible uplift. The hard-coded strings are merely
 placeholders that are hidden by the torbutton overlay.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20707#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list