[tbb-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-usability,                       |  Actual Points:
  TorBrowserTeam201611R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * keywords:  tbb-usability, TorBrowserTeam201611 => tbb-usability,
     TorBrowserTeam201611R
 * status:  new => needs_review


Comment:

 It seems that, even though torbutton is overlaying these checkbox labels
 with localized strings, XUL still wants to look up the original labels in
 tor-browser.git, which exist only in the en-US locale. So the solution
 seems to be to remove any references to localized strings in tor-
 browser.git. But we want to keep those references in our original #20244
 patches so that Mozilla can uplift and localize them. Therefore I'm
 proposing this separate follow-up patch that removes the references for
 Tor Browser only.

 https://github.com/arthuredelstein/tor-browser/commit/20707

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20707#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online