[tbb-bugs] #19410 [Applications/Tor Browser]: Incremental updates from 6.0 to 6.0.1 are not working on OS X

[Tor Bug Tracker & Wiki]

#19410: Incremental updates from 6.0 to 6.0.1 are not working on OS X
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Major                     |     Resolution:
 Keywords:  TorBrowserTeam201606      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by mcs):

 I am able to reproduce this problem. I am not sure why Kathy and I did not
 notice it when we updated from 6.0 to 6.0.1 on two different Mac OS
 systems, but starting with a clean install of 6.0 I see the same problem
 you did.

 Looking at the last-update.log file (located deep under the UpdateInfo
 directory), I see why the incremental update failed to apply:
 {{{
 ...
 EXECUTE PATCH Contents/MacOS/updater.app/Contents/MacOS/updater
 LoadSourceFile: destination file size 106848 does not match expected size
 97000
 LoadSourceFile failed
 ### execution failed
 }}}

 What this means is that the incremental MAR specifies that the size of the
 unpatched Contents/MacOS/updater.app/Contents/MacOS/updater (from 6.0)
 should be 97000 bytes but it is 106848 instead.

 Two possibilities come to mind:
 1. The incremental MAR was generated from the wrong starting version (but
 several files were patched successfully before the updater patch attempt
 failed, so that seems unlikely to me).
 2. There is a bug in the code that generates the incremental MAR.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19410#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online