[tbb-bugs] #19212 [Applications/Tor Browser]: SIGSEGV on particular website with developer tools open

[Tor Bug Tracker & Wiki]

#19212: SIGSEGV on particular website with developer tools open
--------------------------------------+--------------------------
 Reporter:  cypherpunks               |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Very High                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  tbb-crash                 |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by mcs):

 Replying to [comment:11 gk]:
 > So far: this is due to `yield connectTimeline();` in
 https://mxr.mozilla.org/mozilla-esr45/source/devtools/client/netmonitor
 /netmonitor-controller.js#243

 Good find. Avoiding connectTimeline() makes it do timeline events are not
 created, which avoids the codepath where Tor Browser crashes.

 After trying for a while to find the root cause of this issue, Kathy and I
 started to look and see if Mozilla made any changes after ESR45 in code
 near the crash location. We found the following bug which looks like a
 duplicate of this ticket:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1258535
 The crash does disappear when I disable NoScript. Mozilla made two fixes,
 one to add more assertions and one to add an additional null pointer
 check:
  https://hg.mozilla.org/mozilla-central/rev/cd0123e0a09d
  https://hg.mozilla.org/mozilla-central/rev/029c36687f2f
 I am not convinced that they fixed the bug though. Applying their second
 patch did not fix this crash. Kathy and I are about out of time for today,
 but hopefully this gets us a little closer to a solution.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19212#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online