[tbb-bugs] #18019 [Tor Browser]: Update on non-en-US alpha bundles results in empty dialog being shown

[Tor Bug Tracker & Wiki]

#18019: Update on non-en-US alpha bundles results in empty dialog being shown
-------------------------------------+-----------------------------------
 Reporter:  gk                       |          Owner:  tbb-team
     Type:  defect                   |         Status:  needs_information
 Priority:  High                     |      Milestone:
Component:  Tor Browser              |        Version:
 Severity:  Major                    |     Resolution:
 Keywords:  tbb-usablility, tbb-5.5  |  Actual Points:
Parent ID:                           |         Points:
  Sponsor:                           |
-------------------------------------+-----------------------------------
Changes (by mcs):

 * status:  new => needs_information


Comment:

 I am able to reproduce this problem. You are correct -- it is the "Spoof
 English?" prompt. I am not sure why promptService.confirmEx() locks up the
 UI without allowing the prompt dialog to be rendered, but it does on Linux
 at least (not on Mac OS for what that is worth).

 Just before the code in torbutton_new_tab() that opens the prompt, there
 is a comment that reads:
 {{{
 // XXX: This is possibly slightly the wrong place to do this check,
 // but we know the TabOpen effect is late enough to provide the popup
 // after firefox is visible, which makes it more clear whose popup this
 is.
 //
 // Ask the user if they want to make "English requests" if their default
 // language isn't English and the prompt hasn't been displayed before.
 }}}
 Can we move the code that displays the prompt somewhere else? Would it be
 acceptable to display the prompt the first time the browser is opened,
 even if the user never opens a new tab? Currently, users can browser
 without seeing the prompt as long as they do not open a new tab, which
 seems like a bad thing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18019#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online