[tbb-bugs] #16990 [Tor Browser]: Circuit visualizer stops working after some time

[Tor Bug Tracker & Wiki]

#16990: Circuit visualizer stops working after some time
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-torbutton tbb-circuit-display    |        Version:
  TorBrowserTeam201601R, tbb-5.5                 |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Hi, I'm the [comment:9 punk from comment 9].

 Replying to [comment:11 gk]:
 > Okay, I found a way to reproduce at least one issue:
 >
 > 1) Open a new tab and go to https://bugzilla.mozilla.org/ (after it
 loaded the circuit should be visible)
 > 2) Choose Search -> Advanced Search
 > 3) Click on Detailed Bug Information and enter `[tor]` in the Whiteboard
 row
 > 4) Click on Search and after you got your results checking the circuit
 display does not show any curcuit anymore
 >
 > Reloading does not help either. I am not sure if this is caused by our
 fixup done in this bug yet or whether that is an additional issue we
 overlooked so far.

 This is interesting, it is 100% reproducible for any site that serves
 Content-Type "multipart/x-mixed-replace", like bugzilla does for the
 "loading" animation.

 However, note that in this case the circuit display doesn't get screwed up
 for the whole browser, only for that single document on that tab. But I
 think what I observed in 5.0.6 was the same behavior described in the OP
 (though now I'm doubting). Unfortunately I wouldn't know how to reproduce
 that.

 Replying to [comment:13 arthuredelstein]:
 > Here's a patch to do this:
 > ​https://github.com/arthuredelstein/torbutton/commit/16990+1

 Why {{{getSOCKSCredentialsForBrowser}}} returns 2 values as a single
 string, "user:pass" i.e. "host:nonce"?
 That host can include a port which then results in "domain:port:nonce".
 Afterwards there's a

 {{{let domain = credentials.split(":")[0];}}}

 to get the domain, which may be deliberate because later there's

 {{{domain.endsWith(".onion")}}}

 so whoever wrote that expects not to have the ":port" part in "domain".
 But before there's

 {{{document.getElementById("domain").innerHTML = "(" + domain + "):";}}}

 which results in the UI only showing the "domain" part and not the ":port"
 part. But the port is part of the isolation! So shouldn't the user see
 "domain:port" in the UI?

 In any case I think it would be clearer to just return a structure not a
 compound string from {{{getSOCKSCredentialsForBrowser}}}.

 Unrelated to that: the comment for {{{setupDisplay}}} says "Returns a
 function..." but that's not true, it doesn't return anything. I guess
 that's documentation bitrot.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16990#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online