[tbb-bugs] #20147 [Applications/Tor Browser]: [PATCH] (re-)dzip.sh: various improvements

[Tor Bug Tracker & Wiki]

#20147: [PATCH] (re-)dzip.sh: various improvements
-----------------------------------------------+--------------------------
 Reporter:  rustybird                          |          Owner:  tbb-team
     Type:  enhancement                        |         Status:  closed
 Priority:  Medium                             |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:  fixed
 Keywords:  tbb-gitian, TorBrowserTeam201612R  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+--------------------------
Changes (by gk):

 * keywords:  tbb-gitian => tbb-gitian, TorBrowserTeam201612R
 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:16 rustybird]:
 > I just tested it on stretch with the `omni.ja` from stock Firefox ESR
 45.5.1 and got the same warning+error on stderr, as well as exit status 2.
 >
 > (When you tested it on stretch, did you maybe run `re-dzip.sh` with an
 `omni.ja` that already had been re-dzipped by an older version, so the
 problematic extra bytes were no longer present? That was how I had
 previously tested it...)

 Yeah, seems I made the same mistake.

 > Attached: v3 patch, which ignores `unzip` exit status 1 and 2 (i.e.
 everything below "severe" errors)

 I tested it better this time and applied it to `master` and `hardened-
 builds` (commit ea31d520646c07f1565460565f5ead9ad7741b84 and
 3efcbb345fb2cb701226d3c9c659457e7b6ef7bc), thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20147#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online