[tbb-bugs] #19921 [Applications/Tor Browser]: Tor Browser: improper handling of 404 images (was: TBB 6.5a2: something is going wrong)

[Tor Bug Tracker & Wiki]

#19921: Tor Browser: improper handling of 404 images
--------------------------------------+--------------------------
 Reporter:  bugzilla                  |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Major                     |     Resolution:
 Keywords:  tbb-linkability           |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------
Changes (by bugzilla):

 * status:  needs_information => new
 * severity:  Normal => Major


Comment:

 Confirmed for TBB 6.0.4 too: instead of showing
 {{{
 GET https://trac.torproject.org/feed.png [HTTP/1.1 404 Not Found 562ms]
 }}}
 TBB sometimes shows
 {{{
 [08-24 21:00:23] Torbutton INFO: tor SOCKS:
 https://trac.torproject.org/projects/tor/chrome/common/attachment.png via
 torproject.org:c880b1ec9815e42c9f97cc9154f1383a
 [08-24 21:00:23] Torbutton INFO: tor SOCKS:
 https://trac.torproject.org/feed.png via
 torproject.org:c880b1ec9815e42c9f97cc9154f1383a
 NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111
 (NS_ERROR_NOT_AVAILABLE) [nsIHttpChannel.getResponseHeader] content-
 policy.js:67:0
 getFirstPartyURI failed for https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/15842/DisablePlugins.png: 0x80070057
 [08-24 21:00:25] Torbutton INFO: Component returned failure code:
 0x80070057 (NS_ERROR_ILLEGAL_VALUE)
 [mozIThirdPartyUtil.getFirstPartyURIFromChannel]
 [08-24 21:00:25] Torbutton INFO: tor catchall circuit has been dirty for
 over 10 minutes. Rotating.
 [08-24 21:00:25] Torbutton INFO: New domain isolation for --unknown--:
 8f232df465b21a5e26cfca9dec9de45b
 [08-24 21:00:25] Torbutton INFO: tor SOCKS isolation catchall:
 https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/15842/DisablePlugins.png via
 --unknown--:8f232df465b21a5e26cfca9dec9de45b
 }}}
 (The next image is always different, not only DisablePlugins.png)
 There is no easy STR, but you could try some steps to see more fun:
 start TBB, open Console, open Trac timeline, open Page Info and see what's
 going on in the Console and the network load ;)
 Sometimes the bug appears after this, when you refresh the webpage.
 #18361 can be used instead of timeline.
 It's mandatory to restart TBB before every try (because of image caching).

 Update: wow, got this during watching images up and down in Page Info of
 the mentioned ticket and closing it (TBB 6.5a2)
 {{{
 18:14:50.053 A promise chain failed to handle a rejection. Did you forget
 to '.catch', or did you forget to 'return'?
 See
 https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

 Date: Sat Aug 27 2016 18:13:56 GMT+0000 (UTC)
 Full Message: Component returned failure code: 0x80004005
 (NS_ERROR_FAILURE) [imgIRequest.image]
 Full Stack: JS frame :: chrome://browser/content/content.js ::
 PageInfoListener.serializeElementInfo :: line 1189
 JS frame :: chrome://browser/content/content.js ::
 PageInfoListener.getMediaNode/addImage :: line 1082
 JS frame :: chrome://browser/content/content.js ::
 PageInfoListener.getMediaNode :: line 1116
 JS frame :: chrome://browser/content/content.js ::
 PageInfoListener.processFrames :: line 1058
 JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 3151
 content.js:1189:0
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19921#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online