[tbb-bugs] #19528 [Applications/Tor Browser]: The build id stays the same with every Firefox update

[Tor Bug Tracker & Wiki]

#19528: The build id stays the same with every Firefox update
----------------------------------------------+----------------------------
 Reporter:  gk                                |          Owner:  tbb-team
     Type:  defect                            |         Status:
                                              |  needs_revision
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201608  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by boklm):

 Replying to [comment:13 mcs]:
 > A couple of quick comments:
 > * Can we automate the generation of the year portion? Leaving it as 2016
 forever will be a strange thing to do (or if we plan to manually update it
 there is a good chance we will forget to do so). One approach is to use
 the same method we use for COPYRIGHT_YEAR in gitian/descriptors/mac
 /gitian-firefox.yml.

 An other part of the script that we need to manually update is the esr
 branch number that we substract so that it is less than 30. To make sure
 we have an always increasing build ID when the version increase, I think
 we should update the esr number we substract and the year at the same
 time. So I think it is better to have the year manually updated too. I
 updated the script with a comment and separate variables for the year and
 esr branch to make updating that easier.

 But there is still a good chance we will forget to update this. Maybe we
 can raise an error if the year used in the script and the year of the Tor
 Browser commit are different, so we don't forget to update it?

 > * We should carry the build id through to update_responses so that the
 update manifests include the correct build ID.

 I pushed a new branch `bug_19528-v3` doing that:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 bundle.git/commit/?h=bug_19528-v3

 In the bundle step we extract the build id from the `application.ini` file
 and put it in a `buildid.txt` file. The `update_responses` script then
 uses the value from that file as the build id.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19528#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online