[tbb-bugs] #18848 [Applications/Tor Browser]: Additional welcome URL is shown in ESR 45 based Tor Browser

[Tor Bug Tracker & Wiki]

#18848: Additional welcome URL is shown in ESR 45 based Tor Browser
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  High                                 |         Status:  new
Component:  Applications/Tor Browser             |      Milestone:
 Severity:  Major                                |        Version:
 Keywords:  ff45-esr, tbb-6.0a5,                 |     Resolution:
  TorBrowserTeam201604                           |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 This is due to
 {{{
 additionalPage =
 Services.urlFormatter.formatURLPref("startup.homepage_welcome_url.additional");
 }}}

 and

 {{{
     if (additionalPage && additionalPage != "about:blank") {
       if (overridePage) {
         overridePage += "|" + additionalPage;
       } else {
         overridePage = additionalPage;
       }
     }
 }}}
 In Tor Browser based on ESR38 `overridePage` is an empty string.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18848#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online