[tbb-bugs] #18290 [Applications/Tor Browser]: Update Windows toolchain to work with Firefox 45 ESR

[Tor Bug Tracker & Wiki]

#18290: Update Windows toolchain to work with Firefox 45 ESR
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  task                                 |  team
 Priority:  Medium                               |         Status:  closed
Component:  Applications/Tor Browser             |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-gitian, ff45-esr,                |     Resolution:  fixed
  TorBrowserTeam201604, GeorgKoppen201604        |  Actual Points:
Parent ID:  #18226                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:8 bugzilla]:
 > Replying to [comment:3 gk]:
 > > Attached are all the patches we need. I am not happy to back out the
 libraries folding one but for some reason with this patch our builds fail.
 https://bugzilla.mozilla.org/show_bug.cgi?id=1248552 is tracking this.
 > That patch uses unique {{{ifdef MOZ_FOLD_LIBS_FLAGS}}} while the others
 use {{{ifdef MOZ_FOLD_LIBS}}}...
 > It defines {{{MOZ_FOLD_LIBS_FLAGS=-mnop-fun-dllimport}}} while the
 others use quotes...
 > You've already had adventures with that in #10761 and are going to have
 again...

 Thanks for the pointer, but, no, not necessarily. The problem in #10761
 happened due to calling from NSS to NSPR. After libraries are folded there
 is no cross-dll call here anymore. There might be similar problematic
 calls although this is unlikely at least according to Jacek.

 Anyway, we keep the backout for now as the alternative is pulling in a
 bunch of build changes whose stability risks for ESR45 are unknown.

 We bump the mingw-w64 commit we use to
 a0cd5afeb60be3be0860e9a203314c10485bb9b8 as this one is at least needed
 for Tor Browser based on Firefox > 45 anyway.

 arlolra: FWIW: I did not figure out why you don't need the Werror patch
 for Tor Messenger. Even if I use a more or less default .mozconfig and
 default build flags I hit that one when building Tor Browser.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18290#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online