[tbb-bugs] #18290 [Tor Browser]: Update Windows toolchain to work with Firefox 45 ESR

[Tor Bug Tracker & Wiki]

#18290: Update Windows toolchain to work with Firefox 45 ESR
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  task                                 |  team
 Priority:  Medium                               |         Status:  new
Component:  Tor Browser                          |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-gitian, ff45-esr,                |     Resolution:
  TorBrowserTeam201604, GeorgKoppen201604        |  Actual Points:
Parent ID:  #18226                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by bugzilla):

 Replying to [comment:3 gk]:
 > Attached are all the patches we need. I am not happy to back out the
 libraries folding one but for some reason with this patch our builds fail.
 https://bugzilla.mozilla.org/show_bug.cgi?id=1248552 is tracking this.
 That patch uses unique {{{ifdef MOZ_FOLD_LIBS_FLAGS}}} while the others
 use {{{ifdef MOZ_FOLD_LIBS}}}...
 It defines {{{MOZ_FOLD_LIBS_FLAGS=-mnop-fun-dllimport}}} while the others
 use quotes...
 You've already had adventures with that in #10761 and are going to have
 again...
 The right decision was taken in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1151447 (judging by its name
 :)... But seems that only for its naming... And the author continues
 making esr45 codebase happy with the unique flag... It looks like there's
 some misunderstanding of
 https://sourceware.org/binutils/docs-2.26/ld/WIN32.html
 (Mozilla isn't better: releasing version that cannot be built with their
 toolchain! Haha :) They've stolen the proper toolchain somewhere to
 release esr45 :) Here is how to make things right:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1113450. And here is what's
 happening with their Release Engineering
 https://bugzilla.mozilla.org/show_bug.cgi?id=1224408 status-firefox45:
 affected)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18290#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online