[tbb-bugs] #16906 [Tor Browser]: Code for 38.3.0 ESR is failing to compile with mingw-w64
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Sep 18 20:04:39 UTC 2015
#16906: Code for 38.3.0 ESR is failing to compile with mingw-w64
---------------------------+-----------------------------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: closed
Priority: blocker | Milestone:
Component: Tor | Version:
Browser | Keywords: tbb-gitian, TorBrowserTeam201509R
Resolution: fixed | Parent ID:
Actual Points: |
Points: |
---------------------------+-----------------------------------------------
Changes (by gk):
* status: needs_review => closed
* resolution: => fixed
Comment:
Mike had the idea to make this a separate commit in order to get that
upstreamed. I think this is a good idea (at least we could try it). i
adapted your commit accordingly. It is now
ac15e62dc45841a3a21f091fcfa3dc0e455ed637 on tor-browser-38.3.0esr-5.0-2
and a2ebb7e7bf88433bfe056ab543b697dd431d3343 on tor-
browser-38.3.0esr-5.5-2.
Oh, and sorry for my first question. I don't review code with just the
snippets my browser shows me but with the whole files in front of me.
(This is where the "This looks good to me." came from) But then I took a
final glance at the diff and came up with question 2) and then thought
looking further at the diff what about 1) :/ Seems I shouldn't try doing
things in parallel while reviewing code.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16906#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list