[tbb-bugs] #16906 [Tor Browser]: Code for 38.3.0 ESR is failing to compile with mingw-w64 (was: Code for 38.x.0 ESR is failing to compile with mingw-w64)

[Tor Bug Tracker & Wiki]

#16906: Code for 38.3.0 ESR is failing to compile with mingw-w64
----------------------------+----------------------------------------------
     Reporter:  gk          |      Owner:  tbb-team
         Type:  defect      |     Status:  new
     Priority:  blocker     |  Milestone:
    Component:  Tor         |    Version:
  Browser                   |   Keywords:  tbb-gitian, TorBrowserTeam201509
   Resolution:              |  Parent ID:
Actual Points:              |
       Points:              |
----------------------------+----------------------------------------------

Old description:

> https://hg.mozilla.org/releases/mozilla-esr38/rev/be6396f0eb7c fails to
> compile with mingw-w64 and is likely going to get shipped in Firefox
> 38.x.0 ESR. The bug on Mozilla's side is
> https://bugzilla.mozilla.org/show_bug.cgi?id=1199118. WE might get it
> into the same ESR 38 branch as the original bug fix.
>
> If Mozilla does not get this fixed on esr38 we either need to backport a
> patch or come up with one ourselves. glandium and Mike hashed things out
> in #build:
> {{{
> 00:47 < mikeperry> can we link against those libs in an alternate way?
> 00:47 < glandium> OS_LIBS += ['wintrust', 'crypt32'] in the corresponding
>                   moz.build
> 00:51 < mikeperry> so under the existing CONFIG['MOZ_WIDGET_TOOLKIT'] ==
>                    'windows' check in
> toolkit/mozapps/update/common/moz.build
>                    perhaps?
> 00:51 < glandium> mikeperry: sounds right
> 00:53 < mikeperry> am wondering if should use if CONFIG['OS_ARCH'] ==
> 'WINNT'
>                    instead
> 00:53 < glandium> mikeperry: it doesn't really matter
> }}}

New description:

 https://hg.mozilla.org/releases/mozilla-esr38/rev/be6396f0eb7c fails to
 compile with mingw-w64 and is likely going to get shipped in Firefox
 38.3.0 ESR. The bug on Mozilla's side is
 https://bugzilla.mozilla.org/show_bug.cgi?id=1199118.

 If Mozilla does not get this fixed on esr38 we either need to backport a
 patch or come up with one ourselves. glandium and Mike hashed things out
 in #build:
 {{{
 00:47 < mikeperry> can we link against those libs in an alternate way?
 00:47 < glandium> OS_LIBS += ['wintrust', 'crypt32'] in the corresponding
                   moz.build
 00:51 < mikeperry> so under the existing CONFIG['MOZ_WIDGET_TOOLKIT'] ==
                    'windows' check in
 toolkit/mozapps/update/common/moz.build
                    perhaps?
 00:51 < glandium> mikeperry: sounds right
 00:53 < mikeperry> am wondering if should use if CONFIG['OS_ARCH'] ==
 'WINNT'
                    instead
 00:53 < glandium> mikeperry: it doesn't really matter
 }}}

--

Comment (by gk):

 Ugh, scratch the previous comment. It is included.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16906#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online