[tbb-bugs] #16937 [Tor Browser]: The browser.startup.homepage pref has been translated in the Korean bundle

[Tor Bug Tracker & Wiki]

#16937: The browser.startup.homepage pref has been translated in the Korean bundle
-----------------------------+-----------------------------------
     Reporter:  boklm        |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201509R
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------

Comment (by mcs):

 It turns out that the default values for browser.startup.homepage and
 spellchecker.dictionary cannot be directly placed in a prefs file (such as
 defaults/preferences/
 preferences.js within Torbutton). This is because the browser retrieves
 them using the getComplexValue() prefs API. So we must continue to use a
 level of indirection to a properties file.

 If we just want to solve the about:tor problem, we can put the value in a
 file such as src/chrome/content/non-localized.properties within Torbutton,
 change defaults/preferences/
 preferences.js to point to that new file, and then we are done.

 If we also want to avoid bad translations of the spellchecker.dictionary
 values, we should take those out of translators hands as well. But we do
 want different values for different locales, so solving this is a harder.
 We could:
 1. Remove the spellchecker.dictionary values entirely, in which cases
 users will get en-US spellchecking and they will need to choose their
 dictionary after they download and install it.
 2. Create a parallel hierarchy of locale files within Torbutton that do
 not go to/from Transifex, e.g., src/chrome/locale-not-for-translators/.
 The makexpi.sh script would need to be modified to merge the new files
 into the torbutton xpi so the Mozilla code will find them, but that should
 not be too difficult. Introducing a parallel locale hierarchy would be
 ugly because we have a lot of locales.
 3. Change our import-translations.sh script to ignore browser.properties
 so it will never be overwritten with changes from Transifex and de-list
 that file at Transifex. Since it would be confusing to developers to have
 a file under locale/*/ within Torbutton that is not maintained via
 Transifex, we would probably want to rename the file to something like
 not-for-localizers.properties. Then we would have:
      src/chrome/locale/af/not-for-localizers.properties
      src/chrome/locale/ak/not-for-localizers.properties
      ...
      src/chrome/locale/en/not-for-localizers.properties
      etc.

 Opinions? Does anyone have a better idea?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16937#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online