[tbb-bugs] #16940 [Tor Browser]: Implement loading (only) local change notes after a Tor Browser update

[Tor Bug Tracker & Wiki]

#16940: Implement loading (only) local change notes after a Tor Browser update
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  enhancement                     |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Tor Browser                     |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tbb-5.5, TorBrowserTeam201511R  |  Actual Points:
Parent ID:                                  |         Points:
  Sponsor:                                  |
--------------------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:8 gk]:
 > I've tested the patches on Linux and local change notes are working +
 the code looks good. Nice job! Just two things occurred to me while
 testing/reading the code:
 >
 > 1) Should we prepend the value for `startup.homepage_override_url` with
 `about:tbupdate?` as well?

 about:tbupdate? will be prepended to the overridePage whenever the browser
 is starting immediately after applying an update (app.update.postupdate).
 After the call to getPostUpdateOverridePage(), the overridePage value
 might be the startup.homepage_override_url, the value from the update
 manifest (XML from the server), or an empty string. So about:tbupdate?
 will be added to startup.homepage_override_url. Or are we missing
 something?

 > 2) I wonder if we should update the comment above this preference to
 explain what is going on as we don't do this anywhere as far as I can see.
 And using `openURL` gives the wrong impression as we won't open the one
 mentioned there usually. Thus, folks might be confused. If not there, were
 else could mention the "hijacking" of the `openURL` parameter?

 We will update the comment.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16940#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online