[tbb-bugs] #17568 [Tor Browser]: Clean up tor-control-port.js in Torbutton

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 23 13:37:01 UTC 2015


#17568: Clean up tor-control-port.js in Torbutton
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  task                                 |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-torbutton,                       |        Version:
  TorBrowserTeam201511R                          |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:18 gk]:
 > Then there is still the `+`-case from '(the "?" modifier added to "+" or
 "*")' in comment:1, no? Could you make an argument for why we (still) need
 this?

 And for the one after the `*` in
 `string.match(/^250\+.+?=([\s\S]*?)^\.$/m),` as well?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17568#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list