[tbb-bugs] #16990 [Tor Browser]: Circuit visualizer stops working after some time

[Tor Bug Tracker & Wiki]

#16990: Circuit visualizer stops working after some time
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-torbutton tbb-circuit-display    |        Version:
  TorBrowserTeam201511R                          |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Why the non-greedy globbing (the "?" modifier added to "+" or "*") when
 you are matching all the rest of the line anyway?

 Compare:
 {{{
 520 -   let matchResult = string.match(/^250[ -].+?=(.*?)$/mi) ||
 520 +   let matchResult = string.match(/^250[ -].+?=(.*)$/mi) ||
 }}}
 You do this in several other places in this file.  Just wondering, I don't
 think it makes a difference.

 Also, based on the regex above, shouldn't the comment in line 515 be like
 so?
 {{{
 515 -   // or `250 circuit-status...`
 515 +   // or `250 circuit-status=...`
 }}}
 To match the rest of the comment.

 Also, I do not know what the assumptions/pre-conditions are on the input
 string, but you do not check that the first line of the multiline case
 ("!^250\+") ends with "=", as exemplified in the commentary for
 "info.keyValueStringsFromMessage".

 Anyway, sorry for wasting your time, I'm not familiar with this code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16990#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online