[tbb-bugs] #9659 [Tor Browser]: Optimistic Data SOCKS variant (patch for #3875) leads to loop on HTTP requests if no SOCKS response yet

[Tor Bug Tracker & Wiki]

#9659: Optimistic Data SOCKS variant (patch for #3875) leads to loop on HTTP
requests if no SOCKS response yet
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-usability, tbb-crash-hang, tbb-  |        Version:
  firefox-patch, GeorgKoppen201510R,             |     Resolution:
  TorBrowserTeam201511R                          |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------
Changes (by mcs):

 * severity:   => Normal


Comment:

 Kathy and I reviewed the patch from comment:20 and in general tried to
 understand the original patch and what might be going wrong. We are not
 sure that we reproduced the problem that other people experienced, but on
 Mac OS with nsSocketTransport logging enabled we did observe a lot of
 spinning.

 We created a revised patch that includes improved comments and also avoids
 modifying the behavior of the socket state machine when SOCKS is not being
 used (with the patch from comment:20 alone, we observed an assertion
 failure inside the NSPR code for a non-SOCKS connection). It would be good
 to have another review:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug9659-01&id=2cbc406dad55db718bd8a27db4abbd10c0f84bda

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9659#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online