[tbb-bugs] #16577 [Tor Browser]: Verify that Tor Browser patch reverts cause test failures

[Tor Bug Tracker & Wiki]

#16577: Verify that Tor Browser patch reverts cause test failures
---------------------------------+----------------------
     Reporter:  arthuredelstein  |      Owner:  tbb-team
         Type:  task             |     Status:  new
     Priority:  normal           |  Milestone:
    Component:  Tor Browser      |    Version:
   Resolution:                   |   Keywords:  ff38-esr
Actual Points:                   |  Parent ID:
       Points:                   |
---------------------------------+----------------------
Description changed by arthuredelstein:

Old description:

> We should verify that if we revert any of our Tor Browser patches that
> have a corresponding regression test, then the test will fail.
>
> Patches with regression tests:
>
> We have regression tests for the following patches:
> * Bug #5856: Do not expose physical screen info via window &
> window.screen.
> * Bug #2875: Limit device and system specific CSS Media Queries.
> * Bug #2950: Make Permissions Manager memory-only
> * Bug #4755: Return client window coordinates for mouse event screenX/Y
> (for dragend, 0,0 is returned).
> * Bug #2874: Block Components.interfaces from content
>
> Additionally the tests in
> * Bug #13749.1: regression tests for first party isolation of
> localStorage
> * Bug #13749.2: Regression tests for first-party isolation of cache
> cover patches
> * Bug #6564: Isolate DOM storage to first party URI.
> * Bug #6539: Isolate the Image Cache per url bar domain.
> * Bug #13742: Isolate cache to URL bar domain.
> * Bug #10819: Add a pref, "privacy.thirdparty.isolate", to allow the
> activation or deactivation of isolating DOM storage and image caching by
> first party URI.
>
> There are also a couple of regression test patches that I think may be
> broken:
> * TB4: Tor Browser's Firefox preference overrides.
> * Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove
> Amazon, eBay, bing

New description:

 We should verify that if we revert any of our Tor Browser patches that
 have a corresponding regression test, then the test will fail.

 We have regression tests for the following patches:
 * Bug #5856: Do not expose physical screen info via window &
 window.screen.
 * Bug #2875: Limit device and system specific CSS Media Queries.
 * Bug #2950: Make Permissions Manager memory-only
 * Bug #4755: Return client window coordinates for mouse event screenX/Y
 (for dragend, 0,0 is returned).
 * Bug #2874: Block Components.interfaces from content

 Additionally the tests in
 * Bug #13749.1: regression tests for first party isolation of localStorage
 * Bug #13749.2: Regression tests for first-party isolation of cache
 cover patches
 * Bug #6564: Isolate DOM storage to first party URI.
 * Bug #6539: Isolate the Image Cache per url bar domain.
 * Bug #13742: Isolate cache to URL bar domain.
 * Bug #10819: Add a pref, "privacy.thirdparty.isolate", to allow the
 activation or deactivation of isolating DOM storage and image caching by
 first party URI.

 There are also a couple of regression test patches that I think may be
 broken:
 * TB4: Tor Browser's Firefox preference overrides.
 * Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove
 Amazon, eBay, bing

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16577#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online