[tbb-bugs] #13788 [Tor Browser]: Meek bridges don't work in TB 4.5alpha1

[Tor Bug Tracker & Wiki]

#13788: Meek bridges don't work in TB 4.5alpha1
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  cypherpunks            |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  TorBrowserTeam201501R,
  Browser                |  tbb-4.5-alpha-3, MikePerry201501R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 I have now figured out that the first patch I posted here (the
 "simplifications") fixed the meek breakage in one place, but introduced a
 new meek breakage in a new place. Argh.

 So here's a new patch with the just the necessary changes to restore meek,
 without the additional breakage:
 https://github.com/arthuredelstein/tor-
 browser/commit/a06da5112ab3a05e2c87fe40ae26d52cfe8bcca9

 I've tested this patch and meek is working. Virtually all changes in this
 latest patch revert lines in our original [https://gitweb.torproject.org
 /tor-browser.git/commit/?h=tor-
 browser-31.4.0esr-4.5-1&id=7800c9c19d11b574b0483ced85fab0f1abf96444 "Bug
 #3455.2. Allow RFC1929 authentication (username/password) to SOCKS
 servers" commit].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13788#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online