[tbb-bugs] #14429 [Tor Browser]: Automated rounding of content window dimensions

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Feb 13 03:13:08 UTC 2015

#14429: Automated rounding of content window dimensions
     Reporter:           |      Owner:  tbb-team
  arthuredelstein        |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting-resolution, tbb-
  Browser                |  torbutton, TorBrowserTeam201502R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |

Comment (by mikeperry):

 What made you pick 1000ms? If we set this to 100ms or even 10ms, will
 there be issues on some systems? I will play with some timeouts on my
 systems and see if I notice anything, but I was curious if you had a
 reason for picking such a large delay.

 I think there may also be a race/timer resolution issue with the ping()
 function. In one instance, my window was not resized. I'm not sure, but I
 suspect this may be because the '''if (now - lastPingTime >= timeout)'''
 check failed due to the timer actually firing slightly early.

 Also as a general matter, I'm not sure we actually need the grey border
 and the content window quantization for drag-based resizing, but only for
 maximization or other window manager enforced sizing. In other words, it
 seems fine to reveal the intermediate sizes to the content window if the
 user is simply dragging, but it is not fine to reveal the intermediate
 size if the window manager was maximizing or tiling the window. I guess it
 may not be possible to tell the difference in practice, though?

 My statements about trying to not display the grey border during drag
 hinge on how bad we think it is to keep reflowing as if we would allow the
 resize, only to snap back to a size the user wasn't expecting. Maybe I'm
 wrong, and it is actually better to give the user a hint with the grey

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14429#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list