[tbb-bugs] #15564 [Tor Browser]: Isolate SharedWorker by first party domain

[Tor Bug Tracker & Wiki]

#15564: Isolate SharedWorker by first party domain
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-linkability, tbb-usability-      |        Version:
  website, TorBrowserTeam201512R                 |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:9 mcs]:
 > Kathy and I reviewed this and the code looks correct. Nice work! Of
 course we have a few comments:
 >
 > - Since the dom.workers.sharedWorkers.enabled pref is true by default,
 we probably should just remove it from 000-tor-browser.js.
 > - Inside dom/base/test/test_tor_bug15564.html near setPref there is a
 typo in a comment: "prmoise" should be "promise".
 > - Is it customary to close tabs in test code or not? Kathy and I did so
 in docshell/test/test_tor_bug16620.html but you did not here. I can see
 that leaving them open would be helpful for debugging individual test
 cases but I do not know what the norm is for Mozilla test code.
 > - It took us a little while to understand the flow of messages in the
 test code. Maybe add a few comments to help new readers.

 Thanks for the review! I've adopted all of your suggestions and rebased to
 the latest tor-browser 5.5a branch:

 https://github.com/arthuredelstein/tor-browser/commits/15564+3

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15564#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online