[tbb-bugs] #13105 [Tor Browser]: [patch] TorBrowser creates two icons in OS X Dock - confusing

[Tor Bug Tracker & Wiki]

#13105: [patch] TorBrowser creates two icons in OS X Dock - confusing
-------------------------+--------------------------
 Reporter:  teor         |          Owner:  tbb-team
     Type:  defect       |         Status:  new
 Priority:  normal       |      Milestone:
Component:  Tor Browser  |        Version:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
-------------------------+--------------------------
 TorBrowser 3.6.5 creates an additional icon in the dock every time it is
 launched. This could cause user confusion:
 * Why do I have two copies of Tor Browser?
 * Which copy should I use?
 If the user launches Tor Browser using the inner firefox icon, any
 arguments and paths supplied by the outer bundle script will be lost.

 This patch changes the script to use "exec" rather than "open" to launch
 the Tor Browser. This makes sure there is only ever one TorBrowser icon in
 the dock. (Is there any reason "open" was used in the first place?)

 The patch maintains the current behaviour when [-]-debug is used: the
 script launches the executable directly (without using exec or open) so it
 can get the exit status.

 Version: TorBrowser-3.6.5-osx32_en-US.dmg

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13105>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online