[tbb-bugs] #12620 [Tor Browser]: Rebase TBB patches to Firefox 31 and add unit tests

[Tor Bug Tracker & Wiki]

#12620: Rebase TBB patches to Firefox 31 and add unit tests
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  tbb-team
         Type:  task     |     Status:  new
     Priority:  major    |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  ff31-esr, tbb-rebase, tbb-firefox-
   Resolution:           |  patch, TorBrowserTeam201409D
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:26 gk]:
 > Replying to [comment:23 arthuredelstein]:
 > > In trying to apply [https://gitweb.torproject.org/tor-
 browser.git/commit/b1f011d993b4a00db2cb50c49dea38ec5188fdb0 "Backport two
 integer overflow patches], I found that the [https://gitweb.torproject.org
 /tor-
 browser.git/blobdiff/3b338aadd92ac0c3d9584fceea28f8934cdf20f0..b1f011d993b4a00db2cb50c49dea38ec5188fdb0:/js/src/vm
 /Interpreter-inl.h part in Interpreter-inl.h] doesn't apply to ESR31. The
 code in the Interpreter has changed substantially. I think that the ESR31
 version of AddOperation does not protect overflow (which looks like a
 possible security regression for Mozilla), but it will require careful
 study to understand.
 >
 > Those overflows are fixed in ESR 31. So, nothing to backport here.

 OK, this patch has been dropped.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12620#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online