[tbb-bugs] #12620 [Tor Browser]: Rebase TBB patches to Firefox 31 and add unit tests

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Sep 1 08:02:32 UTC 2014

#12620: Rebase TBB patches to Firefox 31 and add unit tests
     Reporter:  gk       |      Owner:  tbb-team
         Type:  task     |     Status:  new
     Priority:  major    |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  TorBrowserTeam201408D, ff31-esr,
   Resolution:           |  tbb-rebase, tbb-firefox-patch
Actual Points:           |  Parent ID:
       Points:           |

Comment (by gk):

 Replying to [comment:23 arthuredelstein]:
 > In trying to apply [https://gitweb.torproject.org/tor-
 browser.git/commit/b1f011d993b4a00db2cb50c49dea38ec5188fdb0 "Backport two
 integer overflow patches], I found that the [https://gitweb.torproject.org
 /Interpreter-inl.h part in Interpreter-inl.h] doesn't apply to ESR31. The
 code in the Interpreter has changed substantially. I think that the ESR31
 version of AddOperation does not protect overflow (which looks like a
 possible security regression for Mozilla), but it will require careful
 study to understand.

 Those overflows are fixed in ESR 31. So, nothing to backport here.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12620#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list