[tbb-bugs] #13324 [Tor Browser]: Generation of incremental MAR files

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Oct 24 19:14:43 UTC 2014

#13324: Generation of incremental MAR files
     Reporter:  boklm    |      Owner:  tbb-team
         Type:  task     |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  TorBrowserTeam201410, ff31-esr,
   Resolution:           |  tbb-4.5-alpha
Actual Points:           |  Parent ID:
       Points:           |

Comment (by mcs):

 The patches look fine to me.  Just a couple of small comments (not
 1. It would be nice to define a function in check-match.sh instead of
 duplicating the code that checks for a match.
 2. Also in check-match.sh, should a non-zero exit occur if no matches for
 the incremental mars are found (when a local sha256sums.incrementals.txt
 file exists)?  I think this would be more consistent with behavior for the
 files listed in sha256sums.txt.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13324#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list