[tbb-bugs] #9906 [Tor Browser]: TBB3 new identity surprises users by closing all tabs

[Tor Bug Tracker & Wiki]

#9906: TBB3 new identity surprises users by closing all tabs
-------------------------+-------------------------------------------------
     Reporter:  torland  |      Owner:  tbb-team
         Type:  defect   |     Status:  new
     Priority:  major    |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  tbb-3.0, tbb-newnym, extdev-
   Resolution:           |  interview, tbb-helpdesk-frequent, tbb-torbutton
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by asn):

 See https://blog.torproject.org/comment/reply/941/79211 for this comment:
 {{{
 I'd like to have an option for not closing the browser window upon
 changing identity.
 There is already a preference "extensions.torbutton.close_newnym" for this
 in about:config, but it doesn't work because a "return" statement is
 missing after the preference test in chrome/content/torbutton.js:


 function torbutton_close_on_toggle(mode, newnym):
 […]
 if (newnym) {
 if (!close_newnym) {
 torbutton_log(3, "Not closing tabs");
 }
 } else if((mode && !close_nontor) || (!mode && !close_tor)) {
 torbutton_log(3, "Not closing tabs");
 return;
 }
 […]
 }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9906#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online