[tbb-bugs] #13672 [Tor Browser]: The circuit display dropdown should be optional.

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Nov 7 19:03:08 UTC 2014

#13672: The circuit display dropdown should be optional.
     Reporter:  yawning      |      Owner:  tbb-team
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201411
Actual Points:               |  Parent ID:
       Points:               |

Comment (by arthuredelstein):

 Replying to [comment:9 gk]:
 > The patch looks good. I'd like to have one thing changed:
 > We should make sure that we call
 > {{{
 > syncDisplayWithSelectedTab(true);
 > collectIsolationData(myController);
 > }}}
 > in `start()` only if there are no errors while calling `controller()`.

 I've updated the patch again. If start() throws an error, it will be
 caught and reported at in the `try { bindPrefAndInit(...) }...` part.
 Note: the anonymous error callback function is called asynchronously,
 which means it will only run after `start()` returns.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13672#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list