[tbb-bugs] #13439 [Tor Browser]: Inspector raises the canvas prompt when hovering over images

[Tor Bug Tracker & Wiki]

#13439: Inspector raises the canvas prompt when hovering over images
-------------------------+-------------------------------------------------
     Reporter:  dcf      |      Owner:  tbb-team
         Type:  defect   |     Status:  needs_review
     Priority:  minor    |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  tbb-easy, tbb-usability,
   Resolution:           |  TorBrowserTeam201412R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gacar):

 I, too, was concerned about this part. I updated the patch, also broke
 down the 80+ line.

 Replying to [comment:17 gk]:
 > Yes, but I was not talking about that part. I was wondering about:
 > {{{
 >         nsPrintfCString msg("On %s: blocked access to canvas image data"
 >                             " from document %s, script from %s:%u ",  //
 L10n
 >                             firstPartySpec.get(), docSpec.get(),
 >                             scriptFile.get(), scriptLine);
 > }}}
 > where the message is constructed with the script file and the respective
 line *regardless* whether `DescribeScriptedCaller` succeeded or not. It
 seems to me if you wrap the former in an if-clause to be defensive (which
 is good, especially as Mozilla has not our patch in its repository yet and
 might change behavior of code we need without us noticing it) you should
 make sure `scriptFile` is updated when constructing the message as well
 (if not we might just give back a generic message without it).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13439#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online