[tbb-bugs] #13671 [Tor Browser]: Circuit display is broken if bridges are being used.

[Tor Bug Tracker & Wiki]

#13671: Circuit display is broken if bridges are being used.
-------------------------+-------------------------------------------------
     Reporter:  yawning  |      Owner:  tbb-team
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  TorBrowserTeam201411,
   Resolution:           |  TorBrowserTeam201411R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:15 gk]:
 > Two comments:
 > 1) just a nit: s/IDS/IDs/

 Fixed.

 > 2) The patch is broken if I select bridges via Torbutton onion -> Open
 Network Settings... -> My Internet Service Provider (ISP) blocks
 connections to the Tor Network
 >
 > In this case I see:
 >
 > {{{
 > [11-25 15:39:12] Torbutton WARN: Error: 552 Unrecognized key
 "ns/id/FINGEPRINT"
 > [11-25 15:39:12] Torbutton WARN: Disabling tor display circuit because
 of an error.
 > }}}

 I've modified the patch to improve error handling. In the case of an
 unrecognized key, it should gracefully handle the error and will no longer
 disable the tor circuit display. (The API functions `sendCommand` and
 `getInfo` in tor-control-port.js have been changed to return Promises, and
 tor-circuit-display.js now uses Firefox's built-in
 [https://developer.mozilla.org/en-
 US/docs/Mozilla/JavaScript_code_modules/Task.jsm Task.jsm] module to
 handle async requests to the control port.)

 > {{{
 > [11-25 15:44:33] Torbutton WARN: Error: 552 Unrecognized key
 "ns/id/6FINGERPRINT"
 > [11-25 15:44:33] Torbutton WARN: Disabling tor display circuit because
 of an error.
 > [11-25 15:44:33] Torbutton WARN: TypeError: gBrowser.tabContainer is
 undefined
 > [11-25 15:44:33] Torbutton WARN: Disabling tor display circuit because
 of an error.
 > gBrowser.tabContainer is undefined
 > }}}

 I now check for the presence of gBrowser.tabContainer so this TypeError
 shouldn't happen any more.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13671#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online