[metrics-team] CollecTor exit-list archive bug

[iwakeh]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 01/10/2017 05:00 PM, Wojtek Porczyk wrote:
> Hello, Metrics Team,
> 
> I belive I found a bug in CollecTor. Since 2016-11-01-09-02-00 the exit list
> archive features "@type torperf" instead of "tordnsel", which makes it
> unreadable in at least stem (python) parser.
> 
>> [woju at REDACTED ~/tmp/exit-list-2016-11/01]$ head 2016-11-01-08-02-00
>> @type tordnsel 1.0
>> Downloaded 2016-11-01 08:02:00
>> ExitNode 0011BD2485AD45D984EC4159C88FC066E5E3300E
[snip]

> 
> Patch fixing this:
> 
> diff --git a/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java b/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
> index 3c2f403..26fbe4b 100644
> --- a/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
> +++ b/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
> @@ -76,7 +76,7 @@ public class ExitListDownloader extends CollecTorMain {
>      try {
>        logger.debug("Downloading exit list...");
>        StringBuilder sb = new StringBuilder();
> -      sb.append(Annotation.Torperf.toString());
> +      sb.append(Annotation.ExitList.toString());
>        sb.append("Downloaded " + dateTimeFormat.format(downloadedDate)
>            + "\n");
>        URL url = config.getUrl(Key.ExitlistUrl);
> 
> You may also pull tag fix-exit-list from https://github.com/woju/collector
> (commit e885283).

Thanks for reporting and analyzing this!
The patch looks fine!

> 
> Can you also fix the already posted files at collector.torproject.org?
> 

These need to be fixed too, that's true.

Kind regards,
iwakeh


> 
> 
> _______________________________________________
> metrics-team mailing list
> metrics-team at lists.torproject.org
> https://lists.torproject.org/cgi-bin/mailman/listinfo/metrics-team
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJYdREmAAoJEPeEx9Sa/gviyeIQAL6MYZeMiJwdgYXDNN+288ps
tp3rLD9ovopMCA3tfExzHwSBIbUbf6+l9dNaNl1WZUggnaoxLF+bO4xeA4dZpvG7
RXrSwXCo9QqSlbB8dTxIxDov353XQF3f7B1NLeS155Su2wEoZK9LpR6E95hBJXQM
Nczs4csZ1mTSvoTUgdUeH10/Z0Cnu1XXkIsI+QG1X0QvsyGxJ11HvPVzByfIrruY
44Uph/UPPQ/jYuUE3keMlKyUcW8A8b9kbyBdTgRtaQqty0sw32yYUDuPUI33Hvk+
ffGhi0wdFYGzAXvzJE8efaiul8scleDtQrUQcVv47DrEsYu+wlKu2RbZuO8dkBTb
oK8zbmR21GW9OMFDeM7hGaVbtdkC0trww8oW9lzuwjvQ1XE+WCQrLXncNTzpgYoc
/F2+XpFJt8ZJFsSqI8s1z8Ya2D6dtdvxfpRBHdHwnoxiILIgdxVEtCHiTTb67X7i
RGaLlPeDnBHbZG5xWxOEXHJaQu3L233CBuX1eWR2REjCPWbiiCMfu6MvvjH/L4Z9
80sC257eTzO9YkgP8vBEJCOYalMayT6i6zduRS4Bz9NK8IRrr0bFggVj+J2yiUdK
WUDToqHyCvcJPpz2zKpUJ2eErLhvO7LYjVtu6CBZiGmaWg/OlNEwXOqRo83/HDfo
NkBHgDRmMylcpNIjzI9k
=SqZF
-----END PGP SIGNATURE-----