[metrics-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

[Tor Bug Tracker & Wiki]

#30586: requirements are not included in setup.py
---------------------------------------+--------------------------------
 Reporter:  irl                        |          Owner:  phw
     Type:  defect                     |         Status:  merge_ready
 Priority:  Medium                     |      Milestone:
Component:  Metrics/Onionperf          |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.35
Parent ID:  #33321                     |         Points:  0.5
 Reviewer:                             |        Sponsor:  Sponsor59-must
---------------------------------------+--------------------------------

Comment (by acute):

 Replying to [comment:10 karsten]:
 > Thanks for these patches! And thanks for copying metrics-team; I had not
 seen the earlier updates (oh, Trac...).
 >
 > So, I tried out this branch without installing all dependencies via
 `sudo apt install python3-*`, and it starts downloading packages via
 `pip`. In our Java projects we have always avoided using package managers
 and only relied on packages provided by the system. We would give up this
 principle here, but are we sure we want to do that? How are we doing this
 in other Python projects at Tor?

 I was wondering whether there is a distinction here that we need to make -
 how do {researchers, developers} install and use onionperf on their
 machines vs how we deploy onionperf in Tor.
 For general purpose use/development, using python-setuptools (which is a
 standard way of packaging python modules and uses pip to manage
 dependencies) and then running onionperf on the command line is entirely
 reasonable.

 For 'official' deployments, not so much. There, it makes more to install
 dependencies directly from Debian, and use a systemd service to run
 Onionperf. The actual 'python3 setup.py install' step is not even
 necessary, as you can just run onionperf directly from the git repository,
 as long as the PYTHONPATH is set. This is mostly what the ansible workflow
 does.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30586#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online