[metrics-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jun 5 18:40:59 UTC 2020


#29369: Fix message logging and filtering
-------------------------------------------------+-------------------------
 Reporter:  irl                                  |          Owner:  phw
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:
Component:  Metrics/Onionperf                    |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  1
  team-roadmap-2020-june                         |
Parent ID:  #33321                               |         Points:  1.0
 Reviewer:  phw                                  |        Sponsor:
                                                 |  Sponsor59-must
-------------------------------------------------+-------------------------
Changes (by phw):

 * status:  needs_review => merge_ready
 * actualpoints:  0.5 => 1


Comment:

 Two comments:
 * `YYYY-MM-YY` should probably be `YYYY-MM-DD`.
 * The string "onionperf.analysis.json.xz" shows up thrice in the save
 function. We could use a variable instead, e.g., `base_filename =
 "onionperf.analysis.json.xz"`.

 Feel free to address these comments as you see fit. I don't think this
 patch requires another review round, so I'm setting it to merge ready and
 adding my 0.5 points.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29369#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list