[metrics-bugs] #32747 [Metrics/CollecTor]: Avoid reprocessing webstats files

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jan 9 11:52:11 UTC 2020

#32747: Avoid reprocessing webstats files
 Reporter:  karsten            |          Owner:  karsten
     Type:  defect             |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
Changes (by karsten):

 * status:  needs_revision => needs_review


 Replying to [comment:2 irl]:
 > The metrics-base commit is ok.
 > The tests look good.

 Great! I'll merge these when the other commit looks good, too.

 > Why have you removed WebServerAccessLogPersistence to duplicate the code
 now in collector/webstats/SanitizeWeblogs.java?
 WebServerAccessLogPersistence is still used by the sync code so we get two
 versions of the same thing both in use.

 The reason was that we now have to calculate the output path of a web
 server access log ''before'' sanitizing, and it seemed easier to just pull
 the rest of the path-computing logic over from the persistence class. But
 I see your point about having this code in two places now.

 I took an alternative approach by adding another constructor to the
 persistence class that we can use when we don't have a sanitized web
 server access log yet. Please review
 squash commit 94b8709] when you get the chance. And please also review
 squash commit 76db495] which fixes a minor bug that I found while testing
 today. Thanks!

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32747#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the metrics-bugs mailing list