[metrics-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
-------------------------------+------------------------------
 Reporter:  karsten            |          Owner:  metrics-team
     Type:  enhancement        |         Status:  new
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------
Changes (by karsten):

 * cc: anarcat, tpa (added)


Comment:

 I updated the script. Changes are:
  - The script now uses argparse to parse arguments.
  - The newly added `-m` argument allows ignoring missing timestamps. This
 makes it possible to also check the backup CollecTor host that doesn't
 archive all descriptor types.

 Regarding the host/address hack, I don't think we'll need that. We can
 simply put in the public DNS name, rather than the host name. Examples:

 {{{
 python3 tor-check-collector -s collector.torproject.org       # for
 colchicifolium
 python3 tor-check-collector -s -m collector2.torproject.org   # for
 corsicum
 }}}

 anarcat, can you review these changes and deploy two checks for the two
 hosts, ideally labeled as "colchicifolium/collector" and
 "corsicum/collector", so that I can quickly notice which one I need to
 fix?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34029#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online