[metrics-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,       |  Actual Points:
  network-team-roadmap-2020Q1                    |
Parent ID:  #33052                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
                                                 |  Sponsor55-can
-------------------------------------------------+-------------------------
Changes (by MrSquanchee):

 * status:  needs_revision => needs_review


Comment:

 Hii teor,

 I think you should review this PR
 https://github.com/torproject/tor/pull/1808 now
 for the documentation, comments and other changes so far.

 Also I looked at the similar functions as rep_hist_bw_stats_write() and
 they seem
 to have no tests, i.e. the functions which write stats to disk and rightly
 so
 because for that we have to mock a lot of lower level functions.

 Suggest me again if I should write a test for this function and if so
 whether
 in test_bwmgt.c or test_stats.c ??

 Thanks :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33617#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online