[metrics-bugs] #32683 [Metrics/Relay Search]: Relay Search should be able to handle non-numbers in "as:" parameter

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Apr 8 00:31:45 UTC 2020


#32683: Relay Search should be able to handle non-numbers in "as:" parameter
----------------------------------+------------------------------
 Reporter:  karsten               |          Owner:  metrics-team
     Type:  defect                |         Status:  merge_ready
 Priority:  Medium                |      Milestone:
Component:  Metrics/Relay Search  |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:                        |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 #8667 is related.

 Relay Search indeed doesn't do any validation of the query before sending
 it. We could return a JSON document along with 400 error codes, to allow
 Onionoo to provide a more detailed message back to the user, but better
 error messages help too.

 It's a bit upsetting that the same error message is in multiple files, I
 should learn more about the template language and see if we can use
 includes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32683#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list