[metrics-bugs] #32605 [Metrics]: Remove external dependencies to implementation classes

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 25 16:18:55 UTC 2019


#32605: Remove external dependencies to implementation classes
-------------------------+--------------------------
 Reporter:  karsten      |          Owner:  karsten
     Type:  enhancement  |         Status:  assigned
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:  irl          |        Sponsor:
-------------------------+--------------------------
Changes (by karsten):

 * reviewer:   => irl


Comment:

 Please review:
  -
 [https://gitweb.torproject.org/user/karsten/collector.git/log/?h=task-32605
 My task-32605 CollecTor branch] with
    - commit 5a0e6be that removes the dependency on metrics-lib's internal
 package, that I had already merged to master, which I can undo by revoking
 this commit if necessary;
    - commit cc3aa57 that removes the dependency on metrics-lib's
 `DescriptorIndexCollector`, that I had also already merged to master; and
    - four commits 859476e to 8263cc7 that remove the dependencies on
 metrics-lib's log package, which is not in master yet.

  - [https://gitweb.torproject.org/user/karsten/metrics-
 web.git/commit/?h=task-32605&id=267678c5742379ecbdfdef18ca362d6950fb09d2
 Commit 267678c in my metrics-web task-32605 branch] that removes the
 dependency on metrics-lib's index package, which is also not in master
 yet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32605#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list