[metrics-bugs] #30544 [Metrics/Library]: Using try-with-resources or close resource

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue May 21 06:45:40 UTC 2019


#30544: Using try-with-resources or close resource
-----------------------------+------------------------------
 Reporter:  fava             |          Owner:  metrics-team
     Type:  defect           |         Status:  new
 Priority:  Medium           |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Major            |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 Would you be able to submit a patch that fixes one instance of this issue?
 It could be a GitHub branch or a patch created with `git format-patch`.

 Regarding the fix, I'd say that using try-with-resources is better than
 explicitly closing the resource. But let's discuss this more once there's
 a patch.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30544#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the metrics-bugs mailing list